Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vault): add update logic for allow events and allow substitution #1085

Merged
merged 2 commits into from
Mar 15, 2024

fix tests

79fdd50
Select commit
Loading
Failed to load commit list.
Merged

fix(vault): add update logic for allow events and allow substitution #1085

fix tests
79fdd50
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 15, 2024 in 1s

62.60% (target 90.00%)

View this Pull Request on Codecov

62.60% (target 90.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.60%. Comparing base (aa44bf3) to head (79fdd50).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   62.57%   62.60%   +0.03%     
==========================================
  Files         345      345              
  Lines       10273    10277       +4     
==========================================
+ Hits         6428     6434       +6     
+ Misses       3368     3367       -1     
+ Partials      477      476       -1
Files Coverage Δ
secret/vault/update.go 92.72% <100.00%> (+4.49%) ⬆️
View more details on Codecov