Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vault): add update logic for allow events and allow substitution #1085

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

ecrupper
Copy link
Contributor

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner March 15, 2024 15:09
wass3rw3rk
wass3rw3rk previously approved these changes Mar 15, 2024
jbrockopp
jbrockopp previously approved these changes Mar 15, 2024
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecrupper ecrupper dismissed stale reviews from jbrockopp and wass3rw3rk via 79fdd50 March 15, 2024 15:17
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.60%. Comparing base (aa44bf3) to head (79fdd50).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   62.57%   62.60%   +0.03%     
==========================================
  Files         345      345              
  Lines       10273    10277       +4     
==========================================
+ Hits         6428     6434       +6     
+ Misses       3368     3367       -1     
+ Partials      477      476       -1     
Files Coverage Δ
secret/vault/update.go 92.72% <100.00%> (+4.49%) ⬆️

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecrupper ecrupper merged commit 0c3e620 into main Mar 15, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/secret/vault/update-update branch March 15, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants