Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button to revert SimpleMDE to plain textarea #10099

Merged
merged 2 commits into from
Feb 1, 2020
Merged

Add button to revert SimpleMDE to plain textarea #10099

merged 2 commits into from
Feb 1, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 1, 2020

This will allow android users to switch off the SimpleMDE editor in the review approve/comment/request changes area.

@zeripath zeripath added type/bug type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 1, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #10099 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10099      +/-   ##
==========================================
- Coverage   43.44%   43.44%   -0.01%     
==========================================
  Files         566      566              
  Lines       78989    78989              
==========================================
- Hits        34320    34316       -4     
  Misses      40432    40432              
- Partials     4237     4241       +4
Impacted Files Coverage Δ
services/pull/patch.go 64.77% <0%> (-3.15%) ⬇️
modules/queue/workerpool.go 46.61% <0%> (-1.78%) ⬇️
services/pull/merge.go 51.36% <0%> (-0.69%) ⬇️
services/pull/pull.go 33.93% <0%> (-0.31%) ⬇️
models/repo.go 51.46% <0%> (+0.13%) ⬆️
services/pull/check.go 56.64% <0%> (+2.09%) ⬆️
models/unit.go 39.5% <0%> (+2.46%) ⬆️
services/pull/temp_repo.go 34.18% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ccd271...6e649f4. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 1, 2020
jolheiser
jolheiser approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to be able to turn it back into an MDE, but other than that LGTM. Can I approve this twice? 😂

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 1, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 1, 2020
@lafriks
Copy link
Member

lafriks commented Feb 1, 2020

Would be nice if it would not initialize simplemde if opened from mobile phone with option to enable it manually

@jolheiser
Copy link
Member

Since this is technically a bug (not being able to easily review on mobile) can it be backported to 1.11? 😁

@zeripath
Copy link
Contributor Author

zeripath commented Feb 1, 2020

make lg-tm work

@zeripath zeripath merged commit f8f6adc into go-gitea:master Feb 1, 2020
@zeripath zeripath deleted the add-button-to-revert-to-plain-textarea branch February 1, 2020 17:07
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 1, 2020
@zeripath
Add button to revert SimpleMDE to plain textarea (go-gitea#10099)
cfab719
@zeripath zeripath mentioned this pull request Feb 1, 2020
Merged
lafriks pushed a commit that referenced this pull request Feb 1, 2020
@zeripath
Add button to revert SimpleMDE to plain textarea (#10099) (#10102)
1ed4323
@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 1, 2020
@6543 6543 mentioned this pull request Feb 2, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @codecov-io @lafriks @jolheiser @GiteaBot