Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] UserSetting to choose witch text editor is defualt (SimpleMDE, textarea, automatic) #10110

Closed
6543 opened this issue Feb 2, 2020 · 11 comments
Labels
outdated/theme/markdown type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@6543
Copy link
Member

6543 commented Feb 2, 2020

enhancement of #10099
as per lunny:

  • automatically, pc SimpleMDE and mobile textarea and this is the default.
  • always SimpleMDE
  • always textarea
@lafriks
Copy link
Member

lafriks commented Feb 2, 2020

I would prefer it not to be user setting but being detected by device - mobile or not

@guillep2k
Copy link
Member

Why not both? Personally I'd rather not use SimpleMDE if that leaves me out of the stock spell checker, mobile or not, but I can understand why most people will benefit from it.

@lunny
Copy link
Member

lunny commented Feb 3, 2020

We could have three options on user settings:

  • automatically, pc SimpleMDE and mobile textarea and this is the default.
  • always SimpleMDE
  • always textarea

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Feb 3, 2020
@6543
Copy link
Member Author

6543 commented Feb 3, 2020

@lunny nice proposal! because each like it different (example i would choose 3, but most will use 1? ...)

@6543 6543 changed the title [Feature] UserSetting to use plain textarea instead of SimpleMDE as default [Feature] UserSetting to choose witch text editor is defualt (SimpleMDE, textarea, automatic) Apr 9, 2020
@corneliusroemer
Copy link

What's the reason for textarea not being the default on mobile? Isn't SimpleMDE on mobile totally broken? Or does it work for most people just not me and a few unlucky other folks?

@zeripath
Copy link
Contributor

No one has coded or submitted a PR to do this.

@corneliusroemer
Copy link

#14017 isn't exactly a allowing the "user" to choose default editor, but it at least disables the broken WYSIWYG on mobile.

@6543
Copy link
Member Author

6543 commented Dec 16, 2020

didnt we migrated already on master to EasyMDE?

@corneliusroemer
Copy link

corneliusroemer commented Dec 16, 2020

@6543 You're right, PR #14017 isn't relevant really to this issue.

@henningoschwald
Copy link

I understand there is currently no way to disable SimpleMDE either per user or globally, is this correct?

I am blind and therefore using a screen reader to interact with Gitea, unfortunately SimpleMDE is not accessible. When moving up or down with the error keys, usually screenreaders read the currently selected line, however in SimpleMDE I am not able to read the text. Furthermore, the keyboard focus is trapped within the text field. Usually the Tab key can be used to move the focus out of the editor, although SimpleMDE seems to block this, maybe to make the Tab key usable for indentation. This however breaks keyboard accessibility.

If you plan to get rid of the WYSIWYG editor anyway, I understand you don't want to put much efford into this, but at least a keyboard shortcut to switch to the plain text area would be great in the meantime. I'l see if I can come up with a PR for this.

Please let me know if there is already a way to disable SimpleMDE per user or for the whole instance. I don't need an editor tool bar with buttons to insert common formatting mark-up, a simple text area where I can enter markdown would be perfectly fine.

@delvh
Copy link
Member

delvh commented Apr 3, 2023

Isn't that pseudo-implemented with #23876 already?
It contains a switch to legacy button, which I think is the best way to handle it for anyone who wants the old easyMDE behavior (if anyone even wants that)

@delvh delvh closed this as completed Apr 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated/theme/markdown type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

9 participants