Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avl): partial revert from #1881 #3534

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Jan 17, 2025

Description

closes #3533

Changed only the node.gno files to before #1881, but kept the implementation of the TraverseInRange function that was modified in #3393.

@notJoon notJoon requested a review from jaekwon January 17, 2025 02:09
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jan 17, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 17, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: notJoon/gno-core)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@notJoon notJoon added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jan 17, 2025
@Kouteki Kouteki requested a review from zivkovicmilos January 17, 2025 12:14
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes from node.gno before 1881: https://www.diffchecker.com/hpbhMjNj/

Looks good.

@thehowl thehowl added security Security-sensitive issue and removed review/triage-pending PRs opened by external contributors that are waiting for the 1st review labels Jan 20, 2025
@thehowl thehowl merged commit 238d5d8 into gnolang:master Jan 20, 2025
17 of 18 checks passed
thehowl added a commit to thehowl/gno that referenced this pull request Jan 20, 2025
thehowl added a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages. security Security-sensitive issue
Projects
Development

Successfully merging this pull request may close these issues.

Revert some changes from #1881
4 participants