Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(p/demo/avl): correct order for IterateByOffset #3393

Merged
merged 7 commits into from
Dec 20, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Dec 20, 2024

the tests were there, but apparently slicesEqual had a bug. lol.

This comes from #3324, and makes it so that IterateByOffset and ReverseIterateByOffset use the correct order. I changed the descending argument of the underlying TraverseByOffset to match it with avl.Node.TraverseInRange.

@thehowl thehowl self-assigned this Dec 20, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 20, 2024
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 20, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@moul
Copy link
Member

moul commented Dec 20, 2024

b28a4e3 fixes another (early-termination) bug that was also detected with #3324.

@thehowl thehowl merged commit 2e332dd into gnolang:master Dec 20, 2024
11 checks passed
albttx pushed a commit that referenced this pull request Jan 10, 2025
the tests were there, but apparently `slicesEqual` had a bug. lol.

This comes from #3324, and makes it so that IterateByOffset and
ReverseIterateByOffset use the correct order. I changed the `descending`
argument of the underlying TraverseByOffset to match it with
avl.Node.TraverseInRange.

---------

Signed-off-by: moul <94029+moul@users.noreply.github.com>
Co-authored-by: moul <94029+moul@users.noreply.github.com>
thehowl pushed a commit that referenced this pull request Jan 20, 2025
# Description

closes #3533 

Changed only the `node.gno` files to before #1881, but kept the
implementation of the `TraverseInRange` function that was modified in
#3393.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants