Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹🚇 Clean up CI #1473

Merged
merged 4 commits into from
Jun 15, 2024
Merged

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Jun 15, 2024

This PR cleans up the CI on staging in order for us to focus on the important parts (result validation).

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

Since the ASV config and benchmark was removed on staging there is no reason to keep the failing CI workflows aound until we reintroduce benchmarks at some point
Since we don't use a GH env for release this would break the release
While the link works their setting prevent bots from visiting it breaking the the CI link check
@s-weigand s-weigand added the staging Issues found in staging branch label Jun 15, 2024
@s-weigand s-weigand requested review from a team as code owners June 15, 2024 12:04
Copy link
Contributor

sourcery-ai bot commented Jun 15, 2024

🧙 Sourcery is reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/remove-ASV-benchmarks

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.1%. Comparing base (4cd51f1) to head (ea77b77).
Report is 19 commits behind head on staging.

Additional details and impacted files
@@           Coverage Diff           @@
##           staging   #1473   +/-   ##
=======================================
  Coverage     85.1%   85.1%           
=======================================
  Files           91      91           
  Lines         3735    3735           
  Branches       630     726   +96     
=======================================
+ Hits          3180    3182    +2     
  Misses         440     440           
+ Partials       115     113    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@s-weigand s-weigand merged commit 898e6d7 into glotaran:staging Jun 15, 2024
36 of 37 checks passed
@s-weigand s-weigand deleted the remove-ASV-benchmarks branch June 15, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging Issues found in staging branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants