Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-3) Allow usage of MemcachedCloud (redislabs.com) #19

Merged
merged 2 commits into from
Mar 20, 2021

Conversation

gep13
Copy link

@gep13 gep13 commented Mar 15, 2021

This PR is based on work that was originally completed by @ferventcoder.

Fixes #3

Previously a user could not control the protocol for working with
memcached. This meant only Text (the default) was available to be used
when working with memcached caches. Allow user to set Protocol as part
of the specific configuration data passed in from a config file.
Previously a user could not control username/password when working with
memcached data stores, even though Enyim Memcached Client supports the
ability for user/pass configuration. All setting username / password as
part of the specific configuration data that can be provided in a
config file.
@glav glav merged commit 2bc2084 into glav:master Mar 20, 2021
@glav
Copy link
Owner

glav commented Mar 20, 2021

Merged. Thanks for this. Will bump the version and repackage

@gep13
Copy link
Author

gep13 commented Mar 20, 2021

Thank you very much!

@gep13 gep13 deleted the ticket/master/GH-3_memcached-with-user-pass branch March 20, 2021 07:02
@gep13
Copy link
Author

gep13 commented Mar 21, 2021

@glav do you have a rough idea on when you would be publishing a new package version?

@glav
Copy link
Owner

glav commented Mar 21, 2021

Right now - here:-) Sorry for the delay.

Note: Updated framewoirk version as well

@gep13
Copy link
Author

gep13 commented Mar 22, 2021

No need to apologise! Thank you very much for getting this pushed out! Will take it for a spin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to - Use Memcached with MemcachedCloud (RedisLabs) that requires user/pass
3 participants