Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to - Use Memcached with MemcachedCloud (RedisLabs) that requires user/pass #3

Closed
glav opened this issue Aug 25, 2017 · 8 comments · Fixed by #19
Closed

How to - Use Memcached with MemcachedCloud (RedisLabs) that requires user/pass #3

glav opened this issue Aug 25, 2017 · 8 comments · Fixed by #19

Comments

@glav
Copy link
Owner

glav commented Aug 25, 2017

There is this nice article out there (https://redislabs.com/memcached-appharbor), but I don't know how to give username and password specifically to Cache.CacheSpecificData. How does one do that?

I'd prefer not to pull out Glav.CacheAdapter and go straight to Enyim to get SASL functionality.

Originally reported by @ferventcoder on Bitbucket at https://bitbucket.org/glav/cacheadapter/issues/39/how-to-use-memcached-with-memcachedcloud

ferventcoder added a commit to ferventcoder/Glav.CacheAdapter that referenced this issue Oct 3, 2018
Previously a user could not control the protocol for working with
memcached. This meant only Text (the default) was available to be used
when working with memcached caches. Allow user to set Protocol as part
of the specific configuration data passed in from a config file.
ferventcoder added a commit to ferventcoder/Glav.CacheAdapter that referenced this issue Oct 3, 2018
Previously a user could not control username/password when working with
memcached data stores, even though Enyim Memcached Client supports the
ability for user/pass configuration. All setting username / password as
part of the specific configuration data that can be provided in a
config file.
@gep13
Copy link

gep13 commented Mar 13, 2021

@glav would you be wiling to accept a Pull Request which added this functionality into your library? Thanks

@glav
Copy link
Owner Author

glav commented Mar 14, 2021

Absolutely! Totally welcome PR's

@glav
Copy link
Owner Author

glav commented Mar 14, 2021

Wow, I totally forgot about this issue too. It has been so long. Please submit a PR and I'd happily merge in.

gep13 pushed a commit to gep13/Glav.CacheAdapter that referenced this issue Mar 15, 2021
Previously a user could not control the protocol for working with
memcached. This meant only Text (the default) was available to be used
when working with memcached caches. Allow user to set Protocol as part
of the specific configuration data passed in from a config file.
gep13 pushed a commit to gep13/Glav.CacheAdapter that referenced this issue Mar 15, 2021
Previously a user could not control username/password when working with
memcached data stores, even though Enyim Memcached Client supports the
ability for user/pass configuration. All setting username / password as
part of the specific configuration data that can be provided in a
config file.
@gep13
Copy link

gep13 commented Mar 15, 2021

@glav thanks for getting back to me! I really appreciate it!

I have created a PR here: #19 which uses work that was originally completed by @ferventcoder, and I am putting it up for review, and hopefully merge into the code base.

Please let me know if you have any questions.

@glav glav closed this as completed in #19 Mar 20, 2021
glav added a commit that referenced this issue Mar 20, 2021
…ser-pass

(GH-3) Allow usage of MemcachedCloud (redislabs.com)
@gep13
Copy link

gep13 commented Mar 22, 2021

@glav sorry to be a pain, but I have just tried to take the new 4.3.0 version of the package for a spin, but it neither the Glav.CacheAdapter or the Glav.CacheAdapter.Core packages seem to contain any dll's. Opening both of the packages within NuGet Explorer show only the license.txt files and the example files:

image

Can you confirm if this is also happening for you? Thanks

@gep13
Copy link

gep13 commented Mar 22, 2021

In the previous release, looks like the assembly was contained within the lib folder in the Glav.CacheAdapter.Core package:

image

@glav
Copy link
Owner Author

glav commented Mar 22, 2021

Oh, I definitely tested it locally prior to upload. Let me have a look

@glav glav reopened this Mar 22, 2021
@glav
Copy link
Owner Author

glav commented Mar 22, 2021

Should be rersolved now. Closing this and will leave #21 open until verified.

@glav glav closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants