-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-493: add module for Gaussian random fields #494
Conversation
Moved this to a new issue: #499 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ntessore! Looks almost ready to me! Sorry for the long review 😬 but see my suggestions and questions below -
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ntessore! Some minor formatting below. I will open up issues for the remaining bits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked through and made various comments.
My main concern is that this is a massive PR, which I really think should be split up.
There have also been design choices which should be discussed, or just done in separate PRs
This PR also undoes a lot of the documentation work done by #381. I think it would be a shame to introduce a lot of code not following that.
Tests are broken FYI |
Implemented changes from review @paddyroddy and @Saransh-cpp. Tests are broken on main. |
They're working for me? And in the UI |
Isn't it |
Ah, yes, you're correct. @Saransh-cpp you are the one in support of |
I am okay with switching to tox, but the bug was more of a GH Action issue this time. The original nox issue was fixed in #471, but the PR did not fix it properly and introduced another issue with caching which popped up now (I missed it in my review 😬). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ntessore! I believe we've created appropriate issues about the conventions/rules changed in this PR, so this should be good to go. I'll wait for @paddyroddy's review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks both, and sorry for the big & complicated PR. These are accumulated changes that would have been difficult to split up again into smaller chunks. |
Move functionality from
gaussiancl
into a new moduleglass.grf
. Transformations of Gaussian random fields can be carried out on all supported array types.This is still a draft: core functionality in
glass
still needs to be expressed in terms of the new module.Closes: #493