Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch over to importing the types from typing #503

Closed
paddyroddy opened this issue Feb 13, 2025 · 0 comments · Fixed by #507
Closed

Switch over to importing the types from typing #503

paddyroddy opened this issue Feb 13, 2025 · 0 comments · Fixed by #507
Assignees
@paddyroddy
Labels
maintenance Maintenance: refactoring, typos, etc. typing Static typing

Comments

@paddyroddy
Copy link
Member

paddyroddy commented Feb 13, 2025 •
edited
Loading

I'd rather switch over to importing the types from typing like most of the ecosystem does. We can open an issue to make the rest of the code consistent.

Originally posted by @ntessore in #494 (comment)
@paddyroddy paddyroddy added maintenance Maintenance: refactoring, typos, etc. typing Static typing labels Feb 13, 2025
@paddyroddy paddyroddy changed the title Switch over to importing the types from typing like most of the ecosystem does. We can open an issue to make the rest of the code consistent. Switch over to importing the types from typing Feb 13, 2025
@paddyroddy paddyroddy mentioned this issue Feb 13, 2025
Merged
@paddyroddy paddyroddy self-assigned this Feb 13, 2025
@paddyroddy paddyroddy mentioned this issue Feb 13, 2025
Merged
5 tasks
paddyroddy added a commit that referenced this issue Feb 14, 2025
@paddyroddy
gh-503: move all typing related imports into from (#507)
10365c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paddyroddy paddyroddy

Labels
maintenance Maintenance: refactoring, typos, etc. typing Static typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-503: move all typing related imports into from glass-dev/glass
1 participant
@paddyroddy