reuse gl-cone3d create_mesh in gl-streamtube3d #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop unused contours - no need for lines and points - remove unused texture argument as well as vertexUVs, cellUVs and cellIntensity
|
💃 -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can help remove rather duplicate JavaScript code from the module by reusing similar functionalities now available in
gl-cone3dmodule after gl-vis/gl-cone3d#18.This should help
plotly.jslibrary which imports both modulesPlease also not that unused
contours,lines,points,texture,vertexUVs,cellUVsandcellIntensitywere removed from the create mesh processes in gl-vis/gl-cone3d#17.cc: @etpinard