Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake cleanup & code hardening #2

Merged
merged 5 commits into from
Jan 4, 2024
Merged

CMake cleanup & code hardening #2

merged 5 commits into from
Jan 4, 2024

Conversation

roncapat
Copy link
Collaborator

@roncapat roncapat commented Jan 3, 2024 •
edited
Loading

Introduces the following warnings:

-Wall -Wextra -Wpedantic -Wconversion -Wdouble-promotion -Wfloat-equal -Wshadow)

Depends on:

Steps:

  • resolve all warnings

@roncapat roncapat self-assigned this Jan 3, 2024
@roncapat roncapat added the enhancement New feature or request label Jan 3, 2024
@roncapat roncapat marked this pull request as ready for review January 4, 2024 15:38
@giafranchini
Copy link
Owner

I tried to build and I don't see any warnings, do you?

@roncapat
Copy link
Collaborator Author

roncapat commented Jan 4, 2024

No warnings 🥇

@roncapat roncapat merged commit 1f63d67 into iron Jan 4, 2024
2 checks passed
@roncapat roncapat deleted the build/cmake_version branch January 4, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roncapat roncapat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roncapat @giafranchini