Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore]: settle a place for convertions used in Chinese translation #172

Merged
merged 9 commits into from
Apr 2, 2022

Conversation

jinjingngo
Copy link
Collaborator

In order to make some agreements in Chinese translation, we need settle a place for conventions, this README is a way we discussed in a issue comment, the reason naming the file to README.md is that we could use the README Feature offered by Github.

@jinjingngo jinjingngo self-assigned this Feb 13, 2022
@ghaiklor
Copy link
Owner

@charleserious the ?? folders are meant to be the source code for the views. Anything that goes there must be present on website. Let's move it to the root of the project, as I mentioned in the issue. I'll update the PR to show you what I mean.

@ghaiklor
Copy link
Owner

To be the "glossary" in its term there is an absent meaning for the term, to be more precise. Maybe you could add a few words about the meaning of the word to explain others why this exact term was chosen.

@jinjingngo
Copy link
Collaborator Author

@charleserious the ?? folders are meant to be the source code for the views. Anything that goes there must be present on website. Let's move it to the root of the project, as I mentioned in the issue. I'll update the PR to show you what I mean.

Sorry for the misunderstanding, and thank you for the correction. 👍

@jinjingngo
Copy link
Collaborator Author

To be the "glossary" in its term there is an absent meaning for the term, to be more precise. Maybe you could add a few words about the meaning of the word to explain others why this exact term was chosen.

Ha, you make the point, and I'll clarify the meaning for the chosen ones.

likui628
likui628 previously approved these changes Feb 16, 2022
Copy link
Owner

@ghaiklor ghaiklor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a meaning missing and still an ongoing discussion about the glossary as a file

@ghaiklor ghaiklor mentioned this pull request Feb 16, 2022
Copy link
Collaborator Author

@jinjingngo jinjingngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likui628 can you help me on these three Variadic Tuple Types, Conditional Types, Flat Type? I don't have any idea on how to express these in Chinese.

@likui628
Copy link
Collaborator

@likui628 can you help me on these three Variadic Tuple Types, Conditional Types, Flat Type? I don't have any idea on how to express these in Chinese.

@charleserious sure, you can review my commit.

2. enhance readability
@jinjingngo
Copy link
Collaborator Author

jinjingngo commented Feb 19, 2022

@likui628 I'v tweaked a little in this commit f21b772, PTAL

likui628
likui628 previously approved these changes Feb 19, 2022
@likui628 likui628 requested a review from ghaiklor February 19, 2022 09:45
@jinjingngo
Copy link
Collaborator Author

jinjingngo commented Feb 19, 2022

There is a meaning missing and still an ongoing discussion about the glossary as a file

@ghaiklor @likui628 I think we're good to go~

@ghaiklor
Copy link
Owner

@charleserious what about making it a list? It looks great in the table, but the source code is hard to read. Let's make it just a list. e.g

- <ENGLISH TERM> (<CHINESE TERM>) - <MEANING>

What do you think?

@jinjingngo
Copy link
Collaborator Author

@ghaiklor Can not come up with more appropriate one, your suggestion looks great.
Thx.

@jinjingngo
Copy link
Collaborator Author

@ghaiklor hey bro, are you ok? Hope you well through this war. ☮️🙏🇺🇦

@ghaiklor
Copy link
Owner

ghaiklor commented Mar 1, 2022

@charleserious hey, still alive, thanks! Our army stands firm against the genocide from Russian occupants.

@jinjingngo
Copy link
Collaborator Author

@ghaiklor send Russians home~

@jinjingngo jinjingngo enabled auto-merge (squash) March 24, 2022 02:28
@jinjingngo jinjingngo merged commit bec0fa5 into main Apr 2, 2022
@jinjingngo jinjingngo deleted the zh/glossary.md branch April 2, 2022 07:14
@jinjingngo
Copy link
Collaborator Author

@ghaiklor Nice to have you back 🤟

@ghaiklor
Copy link
Owner

ghaiklor commented Apr 5, 2022

@charleserious I'm not fully available, but I can have some spare time on a occasion. So feel free to contribute and thanks for this!

@jinjingngo
Copy link
Collaborator Author

@ghaiklor Hope your family going well, I recently focus on my daily job, but I'll keep contributing when I'm free to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants