Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EXAONE model support #9025

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Conversation

mscheong01
Copy link
Collaborator

closes #8991

This is a new model released by LG AI with good english & Korean capabilities
image

Test run:
image

@github-actions github-actions bot added the python python script changes label Aug 14, 2024
@mscheong01 mscheong01 added model Model specific Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix labels Aug 14, 2024
src/llama.cpp Outdated Show resolved Hide resolved
@mscheong01 mscheong01 force-pushed the add-exaone-support branch 2 times, most recently from e76ea3b to ab6528f Compare August 16, 2024 05:09
mscheong01 and others added 4 commits August 16, 2024 14:24
mscheong01 and others added 3 commits August 16, 2024 14:26
Co-Authored-By: compilade <113953597+compilade@users.noreply.github.com>
Co-Authored-By: compilade <113953597+compilade@users.noreply.github.com>
Copy link
Collaborator

@compilade compilade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

src/llama.cpp Outdated Show resolved Hide resolved
Co-authored-by: compilade <git@compilade.net>
@ggerganov ggerganov merged commit c679e0c into ggerganov:master Aug 16, 2024
53 checks passed
@chris-jaehoon
Copy link

thanks for your service!

but I have a problem in quantizing this model. :(

Can you update this feature?

@mscheong01
Copy link
Collaborator Author

@chris-jaehoon I previously checked that the Q4_0 quant works & runs correctly. Can you provide more information on your failed attempt?

@freddydopfel
Copy link

Has anyone uploaded the working model back to Ollama?

arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
* add exaone model support

* add chat template

* fix whitespace

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>

* add ftype

* add exaone pre-tokenizer in `llama-vocab.cpp`

Co-Authored-By: compilade <113953597+compilade@users.noreply.github.com>

* fix lint

Co-Authored-By: compilade <113953597+compilade@users.noreply.github.com>

* add `EXAONE` to supported models in `README.md`

* fix space

Co-authored-by: compilade <git@compilade.net>

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Co-authored-by: compilade <113953597+compilade@users.noreply.github.com>
Co-authored-by: compilade <git@compilade.net>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
* add exaone model support

* add chat template

* fix whitespace

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>

* add ftype

* add exaone pre-tokenizer in `llama-vocab.cpp`

Co-Authored-By: compilade <113953597+compilade@users.noreply.github.com>

* fix lint

Co-Authored-By: compilade <113953597+compilade@users.noreply.github.com>

* add `EXAONE` to supported models in `README.md`

* fix space

Co-authored-by: compilade <git@compilade.net>

---------

Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Co-authored-by: compilade <113953597+compilade@users.noreply.github.com>
Co-authored-by: compilade <git@compilade.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model Model specific python python script changes Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add support for EXAONE-3.0-7.8B-Instruct model
5 participants