Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back top_k #56

Merged
merged 3 commits into from
Mar 12, 2023
Merged

Add back top_k #56

merged 3 commits into from
Mar 12, 2023

Conversation

beiller
Copy link
Contributor

@beiller beiller commented Mar 12, 2023

@ggerganov not sure what you meant by temp is missing it was there. See PR.

utils.cpp Outdated Show resolved Hide resolved
utils.h Outdated Show resolved Hide resolved
@ggerganov ggerganov merged commit 02f0c6f into ggerganov:master Mar 12, 2023
@gjmulder
Copy link
Collaborator

If --top_k is supposed to be working, it doesn't seem to be with the latest code. Also confirmed with 13B, 30B and 65B 4-bit models:

$ git log | head -1
commit 97ab2b257897bfe7e2ae72876a3e50ed41b8c7ce
$ for M in ./models/7B; do for K in 5 10 20 40 80; do echo; echo "$M: --top_k $K"; ./main -m "$M/ggml-model-q4_0.bin" -p "Building a website can be done in 10 simple steps:" -t 16 --top_k $T; echo;done 2> /dev/null; done

./models/7B: --top_k 5
Building a website can be done in 10 simple steps:
Step #2 – Register your domain name. This is the address of your site, like www.yournamehere.com or .net etc… You will need to register this with an ICANN accredited registrar (like GoDaddy) and pay a yearly fee for it ($10-$35).
Step #4 – Choose a web host that meets your needs, like Bluehost which is recommended by WordPress.org or HostGator etc… You will need to sign up with one of these companies in order to have space on the internet where you can upload files and create pages for

./models/7B: --top_k 10
Building a website can be done in 10 simple steps:
Step #2 – Register your domain name. This is the address of your site, like www.yournamehere.com or .net etc… You will need to register this with an ICANN accredited registrar (like GoDaddy) and pay a yearly fee for it ($10-$35).
Step #4 – Choose a web host that meets your needs, like Bluehost which is recommended by WordPress.org or HostGator etc… You will need to sign up with one of these companies in order to have space on the internet where you can upload files and create pages for

./models/7B: --top_k 20
Building a website can be done in 10 simple steps:
Step #2 – Register your domain name. This is the address of your site, like www.yournamehere.com or .net etc… You will need to register this with an ICANN accredited registrar (like GoDaddy) and pay a yearly fee for it ($10-$35).
Step #4 – Choose a web host that meets your needs, like Bluehost which is recommended by WordPress.org or HostGator etc… You will need to sign up with one of these companies in order to have space on the internet where you can upload files and create pages for

./models/7B: --top_k 40
Building a website can be done in 10 simple steps:
Step #2 – Register your domain name. This is the address of your site, like www.yournamehere.com or .net etc… You will need to register this with an ICANN accredited registrar (like GoDaddy) and pay a yearly fee for it ($10-$35).
Step #4 – Choose a web host that meets your needs, like Bluehost which is recommended by WordPress.org or HostGator etc… You will need to sign up with one of these companies in order to have space on the internet where you can upload files and create pages for

./models/7B: --top_k 80
Building a website can be done in 10 simple steps:
Step #2 – Register your domain name. This is the address of your site, like www.yournamehere.com or .net etc… You will need to register this with an ICANN accredited registrar (like GoDaddy) and pay a yearly fee for it ($10-$35).
Step #4 – Choose a web host that meets your needs, like Bluehost which is recommended by WordPress.org or HostGator etc… You will need to sign up with one of these companies in order to have space on the internet where you can upload files and create pages for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants