-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe lower default temp and switch to top_k 40 #42
Comments
|
AFAIK, there is no top k filtering in the current version. The main code uses the The repetition penalty could maybe be ported to this sampler and used instead? I've seen multiple people reporting that FB's default sampler is not adequate for comparing LLaMA's outputs with davinci's. Thus, enabling top k filtering could allow people to experiment with and compare different sampling strategies. |
It does seem to work much better with these options, based on shawwn's patch: I'm not sure what value is ideal for repeat_last_n, but with a little testing, 256 seems to be enough, while 128 wasn't. |
llama.cpp with |
FYI Top K isn't used this PR tho should fix it: |
Need a better strategy to determine default parameters. |
Per this twitter thread. See commit here.
The text was updated successfully, but these errors were encountered: