docker : fix ARM build and Vulkan build #11434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
approved these changes
Jan 26, 2025
|
Hmm, annoyingly, it randomly fails. https://github.com/ngxson/llama.cpp/actions/runs/12977879687/job/36191803983 I'll fire a bug report to github. In the meantime, I'll merge this because CUDA and CPU amd64 builds are too outdated |
|
Created the ticket (unfortunately there is no options to publicly share it)
|
slaren
reviewed
Jan 28, 2025
Comment on lines
+39
to
+40
| - { tag: "cpu", dockerfile: ".devops/cpu.Dockerfile", platforms: "linux/amd64", full: true, light: true, server: true, freediskspace: false} | ||
| - { tag: "cpu", dockerfile: ".devops/cpu.Dockerfile", platforms: "linux/arm64", full: true, light: true, server: true, freediskspace: false} |
There was a problem hiding this comment.
It seems that this doesn't work as expected and only the arm64 image is being published. Should this be reverted?
There was a problem hiding this comment.
hmm yeah. btw, I got the response from github, turns out to be related to this: docker/build-push-action#1309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Test build here: https://github.com/ngxson/llama.cpp/actions/runs/12977412699