Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker : add GGML_CPU_ARM_ARCH arg to select ARM architecture #11419

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

slaren
Copy link
Collaborator

@slaren slaren commented Jan 25, 2025

cont #11403

@slaren slaren requested a review from ngxson as a code owner January 25, 2025 15:25
@github-actions github-actions bot added the devops improvements to build systems and github actions label Jan 25, 2025
@ngxson
Copy link
Collaborator

ngxson commented Jan 25, 2025

I'm testing it on my cloned repo

@ngxson
Copy link
Collaborator

ngxson commented Jan 25, 2025

https://github.com/ngxson/llama.cpp/actions/runs/12966267528

@ngxson
Copy link
Collaborator

ngxson commented Jan 25, 2025

It worked, so I'm merging it now. Thanks.

@ngxson ngxson merged commit 6e264a9 into master Jan 25, 2025
2 checks passed
anagri pushed a commit to BodhiSearch/llama.cpp that referenced this pull request Jan 26, 2025
@ngxson
Copy link
Collaborator

ngxson commented Jan 26, 2025

Not entirely sure why, but CI to build docker still fails with c++: internal compiler error: Segmentation fault signal terminated program collect2 while it works perfectly on my clone repo (which is auto-sync with ggerganov/llama.cpp master branch every 5 minutes)

At this point, the only explanation I can think of is that something happening at runner's hardware level

@slaren slaren deleted the sl/fix-docker-arm-2 branch January 26, 2025 17:31
@slaren
Copy link
Collaborator Author

slaren commented Jan 26, 2025

That's weird, I also tested it locally and it completes successfully on my machine with QEMU.

@ngxson
Copy link
Collaborator

ngxson commented Jan 26, 2025

Hmm sorry I overlooked a bit, the scheduled build failed on my clone repo too: https://github.com/ngxson/llama.cpp/actions/workflows/docker.yml

I'm re-running another build from xsn/test_docker_arm branch which is known to work yesterday. If it doesn't work, there is definitely something to do with runner's hardware: https://github.com/ngxson/llama.cpp/actions/runs/12976884398

@slaren
Copy link
Collaborator Author

slaren commented Jan 26, 2025

If that doesn't work, may be worth to try disabling the cache, or building each platform separately in sequence.

@ngxson
Copy link
Collaborator

ngxson commented Jan 26, 2025

It fails, I'm running another one with AMD/ARM as separated jobs: https://github.com/ngxson/llama.cpp/actions/runs/12977065608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants