Player-based GPU test framework #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ptr, slice, | ||
| }; | ||
|
|
||
| #[derive(serde::Deserialize)] |
There was a problem hiding this comment.
Would it make sense to import this trait and use it without the prefix?
There was a problem hiding this comment.
we totally could, but it's unlikely to substantially reduce the code size in this case, since we only use this a few times
cwfitzgerald
requested changes
Jul 17, 2020
cwfitzgerald
approved these changes
Jul 17, 2020
|
bors r=cwfitzgerald |
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
803: Shader fixes with binary expressions r=kvark a=kvark Goes along with gfx-rs/naga#599 Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
Patryk27
pushed a commit
to Patryk27/wgpu
that referenced
this pull request
Nov 23, 2022
* Add support for int8, int16, and int64 as well as null constant structs * Add support for OpArrayLength to the spirv frontend * Add hacky OpCopyMemory support to spirv frontend * Add OpInBoundsAccessChain to spirv frontend * Add OpLogical(Not)Equal to spirv frontend * Fix several of the issues raised in the pr * Fix the Op::ArrayLength match * Validate accessing structs through pointers * Remove extraneous type check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #786
Description
This change adds a GPU-based testing by re-using the Player from tracing infrastructure - #289.
It converts the player into a lib + binary, and adds an integration test into the crate that implements RON-specified testing.
Current implementation has a few requirements/gotchas that are listed in
test.rs:EmptyMAP_READusage on themSubmitI believe it's workable, and we can improve it down the road (e.g. with #792).
Testing
MUHAHAHA
cargo testnails it