This repository has been archived by the owner on Jan 29, 2025. It is now read-only.
Validate Compose, Unary, Binary, Select, and Relational #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
to gfx-rs/wgpu-rs
that referenced
this pull request
Mar 19, 2021
803: Shader fixes with binary expressions r=kvark a=kvark Goes along with gfx-rs/naga#599 Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
Timo-DK
approved these changes
Mar 19, 2021
| Some(Sk::Uint) | Some(Sk::Sint) | Some(Sk::Float) => true, | ||
| Some(Sk::Bool) | None => false, | ||
| }; | ||
| //TODO: should we be more restrictive here? I.e. expect scalar only to the left. |
There was a problem hiding this comment.
I would say yes, because it can be crucial for the back-ends processing. However, not really needed for now I guess. It is better to push this validation forward first, and iron out the minor things later.
kvark
added a commit
to kvark/wgpu
that referenced
this pull request
Jun 3, 2021
803: Shader fixes with binary expressions r=kvark a=kvark Goes along with gfx-rs/naga#599 Co-authored-by: Dzmitry Malyshau <kvark@fastmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More steps towards #59