New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[naga] allow trailing commas in template lists #7142

Open

kentslaney wants to merge 2 commits into gfx-rs:trunk from kentslaney:template-trailing-commas

Contributor

kentslaney commented Feb 14, 2025 •

edited

Loading

Connections
template list spec

Description
template lists allow for an optional trailing comma, which was not previously accounted for in the lexer

Testing
This is tested by adding trailing commas to the array_size_overrides test

Checklist

Run cargo fmt.
Run taplo format.
Run cargo clippy. If applicable, add:
Run cargo xtask test to run tests.
Add change to CHANGELOG.md. See simple instructions inside file.


          allow trailing commas in template lists

kentslaney requested a review from a team as a code owner

February 14, 2025 19:48


          changelog

18d9509

kentslaney mentioned this pull request

Support getting hit vertex positions. #7141

Closed

4 tasks

cwfitzgerald assigned ErichDonGubler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet