Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builtins ignorelist #86

Merged
merged 5 commits into from
Oct 8, 2022
Merged

Builtins ignorelist #86

merged 5 commits into from
Oct 8, 2022

Conversation

gforcada
Copy link
Owner

@gforcada gforcada commented Oct 8, 2022

Built on top of excellent work from @gsingh93 on #81 I added a few extras on it:

  • tests
  • documentation
  • changes entry
  • rename the option to --builtins-ignorelist to avoid the white/black list connotations

gsingh93 and others added 2 commits October 8, 2022 15:51
Let's try to be more respectful to everyone, and specially in this case
even more clear.
@gforcada gforcada force-pushed the builtins-whitelist branch from 8e82902 to 2dff078 Compare October 8, 2022 13:56
@gforcada gforcada merged commit b3461fb into master Oct 8, 2022
@gforcada gforcada deleted the builtins-whitelist branch October 8, 2022 13:57
@gforcada
Copy link
Owner Author

gforcada commented Oct 8, 2022

@gsingh93 @cclauss I released flake8-builtins 2.0.0 if you have time, not only to report and contribute to it, but also to test the new release, that would be awesome! 🤩

@gsingh93
Copy link
Contributor

gsingh93 commented Oct 8, 2022

I tested it and it works great. I ended up integrating it into my project, thanks for taking the time to update it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants