Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist the copyright builtin by default #81

Closed
wants to merge 1 commit into from
Closed

Whitelist the copyright builtin by default #81

wants to merge 1 commit into from

Conversation

gsingh93
Copy link
Contributor

@gsingh93 gsingh93 commented Oct 6, 2022

If we're whitelist credits by default, I think it makes sense to also whitelist copyright by default.

@gforcada
Copy link
Owner

gforcada commented Oct 8, 2022

@gsingh93 thanks for the pull request! Do you mind if I take your code and polish it a little bit?

  • I would rename whitelist to ignorelist
  • tests are missing
  • changelog entry as well
  • mention of the new option on the README, with an example on how to use it

@gforcada gforcada mentioned this pull request Oct 8, 2022
Merged
@gforcada
Copy link
Owner

gforcada commented Oct 8, 2022

@gsingh93 I created #86 based on this branch of yours, thanks a lot for this PR! 🎉 I was long waiting to implement this myself, but never got around to do it, fortunately you came across and safe the day! 🤩

@gforcada gforcada closed this Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsingh93 @gforcada