-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major cleanup: python versions, versions pinned and github actions #85
Conversation
5999d54
to
c5e9206
Compare
Have you used https://pre-commit.com ? That would have formatting tools like black, isort, pyupgrade, autoflake reformat the code as its being committed locally. It saves roundtrips. |
c7c663f
to
22c4a0b
Compare
And when fixing it to run, it does so fine locally, but not in GitHub actions :-/
22c4a0b
to
6612071
Compare
Python 3.7 is still officially supported until summer 2023.
Regarding the CI failure, I see in the README for typed_ast: "Due to reliance on certain C APIs, this library does not build on and there are no plans to support PyPy." |
6612071
to
8e22676
Compare
8e22676
to
116135d
Compare
@gsingh93 thanks, yes, I noticed that, I'm fixing this and making the github workflow file a bit more understandable and I think I will merge it in a bit 😄 |
330f2cd
to
414e044
Compare
@gsingh93 fortunately we can avoid the |
414e044
to
16d70c3
Compare
I had to remove We might add them later back, I don't want to hold this any longer 👍🏾 |
Finally I have some time to spend on setting a new base for
flake8-builtins
future ✨requirements.txt
were updated, which will remove the security warnings GitHub is displayingI always like to create lots of commits with each doing one specific topic, so although the changes are quite a lot, they are all (hopefully) isolated 🤞🏾 😄
@cclauss @gsingh93 you might want to have a look. I will review and merge your PR on top of this one, if I manage to make this one pass CI, my skills level on GitHub actions is rather low 😓 today is already improving this 😄