Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major cleanup: python versions, versions pinned and github actions #85

Merged
merged 8 commits into from
Oct 8, 2022

Conversation

gforcada
Copy link
Owner

@gforcada gforcada commented Oct 8, 2022

Finally I have some time to spend on setting a new base for flake8-builtins future ✨

  • python 2.7 and 3.6 support was removed, which allows to remove quite some code
  • version pins on requirements.txt were updated, which will remove the security warnings GitHub is displaying
  • GitHub actions was updated, to ensure the supported python versions are actually working

I always like to create lots of commits with each doing one specific topic, so although the changes are quite a lot, they are all (hopefully) isolated 🤞🏾 😄

@cclauss @gsingh93 you might want to have a look. I will review and merge your PR on top of this one, if I manage to make this one pass CI, my skills level on GitHub actions is rather low 😓 today is already improving this 😄

@gforcada gforcada force-pushed the drop-py2-py36 branch 8 times, most recently from 5999d54 to c5e9206 Compare October 8, 2022 11:40
@cclauss
Copy link
Contributor

cclauss commented Oct 8, 2022

Have you used https://pre-commit.com ? That would have formatting tools like black, isort, pyupgrade, autoflake reformat the code as its being committed locally. It saves roundtrips.

@gforcada gforcada force-pushed the drop-py2-py36 branch 2 times, most recently from c7c663f to 22c4a0b Compare October 8, 2022 11:48
And when fixing it to run, it does so fine locally, but not in GitHub
actions :-/
Python 3.7 is still officially supported until summer 2023.
@gsingh93
Copy link
Contributor

gsingh93 commented Oct 8, 2022

Regarding the CI failure, I see in the README for typed_ast: "Due to reliance on certain C APIs, this library does not build on and there are no plans to support PyPy."

@gforcada
Copy link
Owner Author

gforcada commented Oct 8, 2022

@gsingh93 thanks, yes, I noticed that, I'm fixing this and making the github workflow file a bit more understandable and I think I will merge it in a bit 😄

@gforcada
Copy link
Owner Author

gforcada commented Oct 8, 2022

@gsingh93 fortunately we can avoid the type_ast problem by using a pypy version that targets python 3.8+ 🎉

@gforcada
Copy link
Owner Author

gforcada commented Oct 8, 2022

I had to remove hypothesis tests, as they were running mostly fine locally, but failing at running on GitHub actions 😕

We might add them later back, I don't want to hold this any longer 👍🏾

@gforcada gforcada merged commit f0220bc into master Oct 8, 2022
@gforcada gforcada deleted the drop-py2-py36 branch October 8, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants