-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flake-job to CI #47
Comments
@Bengt thanks for taking the time to create the issue ✨ Would you mind to explain a bit more what you mean? 🤔 you want another job on the travis CI matrix so that it runs flake8-builitins against this repo? 🤔 While that would be a good idea, I miss the point of the |
Hi, @gforcada! Thanks for thinking about this. Yes, I mean checking this repo against itself. On the one hand this would assure that the code quality of this repo reaches a certain level. On the other hand this demonstrate the applicability of the package in a real software project. People who want to follow this example could copy your Travis matrix definition to theirs in the certainty that the commands work in a realistic environment. So that would be a good starting point. |
With #85 I think we are doing enough QA on the code, if you still think we should do more, please re-open the issue 😄 |
Hi, @gforcada! I am happy to see that you picked up GitHub actions for this project. As far as I can see, you are not "eating your own dog food" by using your own linter, though. The workflow includes flake8, but without flake8-builtins: https://github.com/gforcada/flake8-builtins/blob/master/.github/workflows/testing.yml#L50 |
To test the code against the latest released version of
flake-builtins
and demonstrate its usage.The text was updated successfully, but these errors were encountered: