Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to jobs and call fxns #46

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Minor improvements to jobs and call fxns #46

merged 2 commits into from
Aug 8, 2024

Conversation

sckott
Copy link
Member

@sckott sckott commented Aug 7, 2024

Description

Tweaks to cromwell_jobs and cromwell_call for better output for users

jobs: reorder columns
call: always output tibble

Related Issue

#42

Example

cromwell_jobs(21)
#> # A tibble: 4 × 8
#>   workflow_name       workflow_id status submission          start               end                 workflowDuration metadataArchiveStatus
#>   <chr>               <chr>       <chr>  <dttm>              <dttm>              <dttm>                         <dbl> <chr>
#> 1 hello_hostname      4e38ceca-0… Succe… 2024-07-26 16:00:37 2024-07-26 16:00:41 2024-07-26 16:00:48            0.183 Unarchived
#> 2 hello_hostname      32b3fea6-f… Succe… 2024-07-26 12:38:36 2024-07-26 12:38:49 2024-07-26 12:38:57            0.35  Unarchived
#> 3 HelloDockerHostname 677e0d63-e… Succe… 2024-07-17 15:09:47 2024-07-17 15:09:51 2024-07-17 15:12:45            2.97  Unarchived
#> 4 hello_hostname      311a39b0-d… Succe… 2024-07-17 15:09:22 2024-07-17 15:09:31 2024-07-17 15:09:45            0.383 Unarchived
cromwell_call(cromwell_jobs(21)$workflow_id[1])
#> # A tibble: 1 × 22
#>   workflowName   callName executionStatus stdout   shardIndex returnCode backend end   start
#>   <chr>          <chr>    <chr>           <chr>    <chr>      <chr>      <chr>   <chr> <chr>
#> 1 hello_hostname hostname Done            /fh/scr… -1         0          gizmo   2024… 2024…
#> # ℹ 13 more variables: stderr <chr>, callRoot <chr>, attempt <chr>, failOnStderr <chr>,
#> #   partition <chr>, continueOnReturnCode <chr>, modules <chr>, gpus <chr>,
#> #   maxRetries <chr>, cpu <chr>, memory <chr>, workflow_id <chr>, callDuration <dbl>

Testing

  • tests all pass
  • improved tests a bit
  • tested on shiny cromwell locally and all works good

@sckott sckott added the enhancement New feature or request label Aug 7, 2024
@sckott sckott added this to the rcromwell v3.2.4 milestone Aug 7, 2024
@sckott sckott requested a review from tefirman August 7, 2024 17:02
Copy link
Member

@tefirman tefirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end as well, thanks @sckott !

@tefirman tefirman merged commit 968d0ad into dev Aug 8, 2024
4 checks passed
@sckott sckott deleted the cosmetics branch August 8, 2024 16:09
@tefirman tefirman mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants