Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small cosmetic suggestion for cromwell_jobs() #42

Closed
jayoung opened this issue Jun 12, 2024 · 4 comments
Closed

small cosmetic suggestion for cromwell_jobs() #42

jayoung opened this issue Jun 12, 2024 · 4 comments
Assignees
Labels
low priority Not urgent or critical, implement whenever v1.1 Should be implemented in PROOF v1.1

Comments

@jayoung
Copy link

jayoung commented Jun 12, 2024

hi there,

as I explore rcromwell, I can tell that every time I run cromwell_jobs() I'm going to want to do something like this every time:

cromwell_jobs() %>% print(width=Inf)

or even better, this

cromwell_jobs() %>% relocate(workflow_name, status, submission, start) %>% print(width=Inf) 

So my suggestion is to make cromwell_jobs() arrange the columns of its output tibble in a user-friendly order.

picky! sorry.

Janet

@jayoung
Copy link
Author

jayoung commented Jun 12, 2024

another cosmetic-ish thing: how about making cromwell_call() emit its output as a tibble (rather than data.frame), to be consistent with the output of cromwell_jobs() ? Either tibble or data.frame is good but consistency between functions in the same package is nice.

@tefirman
Copy link
Member

tefirman commented Jul 30, 2024

@jayoung -- Totally agree on the column order of cromwell_jobs, it would be much more convenient in the order we have it on the "Workflows Run" table of the Shiny app (see screenshot below). We can definitely fix that!

As for the cromwell_call output, I'm seeing that returning tibbles on my end. Is there a particular job you used that returned a data.frame (job ID, WDL script, etc)?

image

@tefirman tefirman added low priority Not urgent or critical, implement whenever v1.1 Should be implemented in PROOF v1.1 labels Jul 30, 2024
@tefirman tefirman added this to the PROOF v1.1 milestone Jul 30, 2024
@jayoung
Copy link
Author

jayoung commented Aug 1, 2024

thanks, Taylor - glad my small comments are not annoying!

Don't think I'll be able to reconstruct the cromwell_call -> data.frame thing - sorry! It's too long ago now that I saw that. I'm not using WDLs very often. If I do see it again I'll try to remember to give you a job ID, but maybe we should just assume that I imagined it :)

@sckott
Copy link
Member

sckott commented Aug 7, 2024

Thanks @jayoung

Made fixes for these two functions in PR #46

@sckott sckott modified the milestones: PROOF v1.1, rcromwell v3.2.4 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Not urgent or critical, implement whenever v1.1 Should be implemented in PROOF v1.1
Projects
None yet
Development

No branches or pull requests

3 participants