Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uptime): Correct seat error validation format #85574

Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix(uptime): Correct seat error validation format #85574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f09f2dd
fix(uptime): Correct seat error validation format
evanpurkhiser Feb 20, 2025
fa6acaa
Merge branch 'master' into evanpurkhiser/fix-uptime-correct-seat-erro…
evanpurkhiser Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sentry/uptime/endpoints/validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,9 @@ def update(self, instance: ProjectUptimeSubscription, data):
# Nest seat availability errors under status. Since this is the
# field that will trigger seat availability errors.
if err.result is None:
raise serializers.ValidationError({"status": "Cannot enable uptime monitor"})
raise serializers.ValidationError({"status": ["Cannot enable uptime monitor"]})
else:
raise serializers.ValidationError({"status": err.result.reason})
raise serializers.ValidationError({"status": [err.result.reason]})
finally:
create_audit_entry(
request=self.context["request"],
Expand Down
2 changes: 1 addition & 1 deletion tests/sentry/uptime/endpoints/test_project_uptime_alert_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def test_status_enable_no_seat_assignment(self, _mock_check_assign_seat):
uptime_monitor.refresh_from_db()
assert uptime_monitor.status == ObjectStatus.DISABLED
assert resp.data == {
"status": ErrorDetail(string="Assignment failed in test", code="invalid")
"status": [ErrorDetail(string="Assignment failed in test", code="invalid")]
}


Expand Down
Loading