Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uptime): Correct seat error validation format #85574

Conversation

evanpurkhiser
Copy link
Member

These need to be arrays to be properly handled by the frontend. All
other errors come back correctly as arrays.

These need to be arrays to be properly handled by the frontend. All
other errors come back correctly as arrays.
@evanpurkhiser evanpurkhiser requested a review from a team as a code owner February 20, 2025 19:41
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 20, 2025
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) February 20, 2025 23:47
Copy link

codecov bot commented Feb 21, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
23608 2 23606 291
View the top 2 failed test(s) by shortest run time
tests.snuba.tagstore.test_tagstore_backend.TagStorageTest::test_get_group_tag_key_generic
Stack Traces | 7.32s run time
#x1B[1m#x1B[.../snuba/tagstore/test_tagstore_backend.py#x1B[0m:554: in test_get_group_tag_key_generic
    assert (
#x1B[1m#x1B[.../tagstore/snuba/backend.py#x1B[0m:479: in get_group_tag_key
    return self.__get_tag_key_and_top_values(
#x1B[1m#x1B[.../tagstore/snuba/backend.py#x1B[0m:207: in __get_tag_key_and_top_values
    raise TagKeyNotFound if group is None else GroupTagKeyNotFound
#x1B[1m#x1B[31mE   sentry.tagstore.exceptions.GroupTagKeyNotFound#x1B[0m
tests.snuba.tagstore.test_tagstore_backend.TagStorageTest::test_get_group_tag_keys_and_top_values_generic_issue
Stack Traces | 7.52s run time
#x1B[1m#x1B[.../snuba/tagstore/test_tagstore_backend.py#x1B[0m:295: in test_get_group_tag_keys_and_top_values_generic_issue
    assert set(tags) == {"foo", "biz", "environment", "sentry:user", "level", "sentry:release"}
#x1B[1m#x1B[31mE   AssertionError: assert set() == {'biz', 'envi...'sentry:user'}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Extra items in the right set:#x1B[0m
#x1B[1m#x1B[31mE     'foo'#x1B[0m
#x1B[1m#x1B[31mE     'sentry:user'#x1B[0m
#x1B[1m#x1B[31mE     'environment'#x1B[0m
#x1B[1m#x1B[31mE     'sentry:release'#x1B[0m
#x1B[1m#x1B[31mE     'level'#x1B[0m
#x1B[1m#x1B[31mE     'biz'#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE     + set()#x1B[0m
#x1B[1m#x1B[31mE     - {#x1B[0m
#x1B[1m#x1B[31mE     -     'biz',#x1B[0m
#x1B[1m#x1B[31mE     -     'environment',#x1B[0m
#x1B[1m#x1B[31mE     -     'foo',#x1B[0m
#x1B[1m#x1B[31mE     -     'level',#x1B[0m
#x1B[1m#x1B[31mE     -     'sentry:release',#x1B[0m
#x1B[1m#x1B[31mE     -     'sentry:user',#x1B[0m
#x1B[1m#x1B[31mE     - }#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@evanpurkhiser evanpurkhiser merged commit 1791a32 into master Feb 21, 2025
49 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/fix-uptime-correct-seat-error-validation-format branch February 21, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants