ref(metrics): Change push_scope to new_scope
#75043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75043 +/- ##
=======================================
Coverage 78.12% 78.12%
=======================================
Files 6748 6748
Lines 301190 301189 -1
Branches 51831 51830 -1
=======================================
Hits 235305 235305
+ Misses 59555 59554 -1
Partials 6330 6330
|
`sentry_sdk.push_scope` is soft-deprecated, and will soon be hard- deprecated (see sentry-python#3347), so replace the `push_scope` calls with appropriate new API. Here, we use `sentry_sdk.new_scope`, since we are setting tags for a `capture_message` call. Closes #74938
2ec7928 to
cf287e1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentry_sdk.push_scopeis soft-deprecated, and will soon be hard- deprecated (see sentry-python#3347), so replace thepush_scopecalls with appropriate new API. Here, we usesentry_sdk.new_scope, since we are setting tags for acapture_messagecall.Closes #74938