Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate sentry_sdk.push_scope #3347

Closed
szokeasaurusrex opened this issue Jul 25, 2024 · 0 comments · Fixed by #3355
Closed

Deprecate sentry_sdk.push_scope #3347

szokeasaurusrex opened this issue Jul 25, 2024 · 0 comments · Fixed by #3355
Assignees
@szokeasaurusrex

Comments

@szokeasaurusrex
Copy link
Member

Calling sentry_sdk.push_scope should emit a DeprecationWarning. Add a test to verify this behavior
This was referenced Jul 25, 2024
Closed
Merged
Merged
szokeasaurusrex added a commit to getsentry/sentry that referenced this issue Jul 26, 2024
@szokeasaurusrex
ref(metrics): Change push_scope to new_scope (#75043)
ed28b1f 
`sentry_sdk.push_scope` is soft-deprecated, and will soon be hard-
deprecated (see
[sentry-python#3347](getsentry/sentry-python#3347)),
so replace the `push_scope` calls with appropriate new API. Here, we use
`sentry_sdk.new_scope`, since we are setting tags for a
`capture_message` call.

Closes #74938
@szokeasaurusrex szokeasaurusrex self-assigned this Jul 26, 2024
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
fix(api): push_scope deprecation warning
b74c30e 
Although `push_scope` was meant to be deprecated since Sentry
SDK 2.0.0, calling `push_scope` did not raise a deprecation
warning. Now, it does.

Fixes #3347
@szokeasaurusrex szokeasaurusrex mentioned this issue Jul 26, 2024
Merged
@szokeasaurusrex szokeasaurusrex linked a pull request Jul 26, 2024 that will close this issue
fix(api): push_scope deprecation warning #3355
Merged
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
fix(api): push_scope deprecation warning (#3355)
54ad7ed 
Although `push_scope` was meant to be deprecated since Sentry
SDK 2.0.0, calling `push_scope` did not raise a deprecation
warning. Now, it does.

Fixes #3347
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
fix(api): push_scope deprecation warning (#3355)
21eb829 
Although `push_scope` was meant to be deprecated since Sentry
SDK 2.0.0, calling `push_scope` did not raise a deprecation
warning. Now, it does.

Fixes #3347
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
fix(api): push_scope deprecation warning (#3355) (#3355)
194e430 
Although `push_scope` was meant to be deprecated since Sentry
SDK 2.0.0, calling `push_scope` did not raise a deprecation
warning. Now, it does.

Fixes #3347
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this issue Sep 30, 2024
@szokeasaurusrex @arjenzorgdoc
fix(api): push_scope deprecation warning (getsentry#3355) (getsentr…
128c323 
…y#3355)

Although `push_scope` was meant to be deprecated since Sentry
SDK 2.0.0, calling `push_scope` did not raise a deprecation
warning. Now, it does.

Fixes getsentry#3347
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api): push_scope deprecation warning getsentry/sentry-python
1 participant
@szokeasaurusrex