Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feedback): add option for ingest feedback topic #67839

Merged
merged 3 commits into from
Mar 28, 2024
Merged

feat(feedback): add option for ingest feedback topic #67839

merged 3 commits into from
Mar 28, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Mar 27, 2024 •
edited
Loading

relates to #66100

@aliu39 aliu39 requested a review from a team as a code owner March 27, 2024 23:12
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 27, 2024
@aliu39 aliu39 requested a review from a team March 27, 2024 23:13
bruno-garcia
bruno-garcia reviewed Mar 27, 2024
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a ticket this rolls up to that we should link to?

@aliu39 aliu39 requested a review from a team March 27, 2024 23:43
@aliu39 aliu39 mentioned this pull request Mar 27, 2024
Merged
Dav1dde
Dav1dde approved these changes Mar 28, 2024
View reviewed changes
src/sentry/options/defaults.py Show resolved Hide resolved
@aliu39 aliu39 enabled auto-merge (squash) March 28, 2024 16:01
@aliu39 aliu39 merged commit 7e3ded7 into master Mar 28, 2024
49 checks passed
@aliu39 aliu39 deleted the aliu/feedback-topic-option branch March 28, 2024 17:30
aliu39 added a commit to getsentry/relay that referenced this pull request Apr 9, 2024
@aliu39
feat(feedback): produce to ingest-feedback-events topic (#3344)
01311a4 
Option PR:
depends on getsentry/sentry#67839 (MERGED)

Feature flag PRs (outdated/unused):
~getsentry/getsentry#13426 (REVERTED)~
~getsentry/sentry#67747 (REVERTED)~
~getsentry/sentry-options-automator#973
(CLOSED)~

Relates to getsentry/sentry#66100
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bruno-garcia bruno-garcia bruno-garcia left review comments

@Dav1dde Dav1dde Dav1dde approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliu39 @Dav1dde @bruno-garcia