Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feedback): add ff for ingest feedback topic #67747

Merged
merged 2 commits into from
Mar 27, 2024
Merged

feat(feedback): add ff for ingest feedback topic #67747

merged 2 commits into from
Mar 27, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Mar 26, 2024 •
edited by bruno-garcia
Loading

Relates to: #66100

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 26, 2024
@michellewzhang
Copy link
Member

do we also need to modify sever.py?

sentry/src/sentry/conf/server.py

Line 1844 in 3600c1d

"organizations:session-replay": False,

@cmanallen

@aliu39
Copy link
Member Author

aliu39 commented Mar 26, 2024 •
edited
Loading

do we also need to modify sever.py?

Oh yup, good call!

@aliu39 aliu39 requested a review from a team as a code owner March 26, 2024 21:58
@aliu39
Copy link
Member Author

aliu39 commented Mar 26, 2024 •
edited
Loading

Added to EXPOSABLE_FEATURES so relay can read it from project config -- see comment here. Useful for future relay flags @cmanallen

@aliu39 aliu39 mentioned this pull request Mar 26, 2024
Merged
@aliu39 aliu39 merged commit bb59152 into master Mar 27, 2024
48 checks passed
@aliu39 aliu39 deleted the aliu/ingest-feedback-ff branch March 27, 2024 16:59
aliu39 added a commit that referenced this pull request Mar 27, 2024
@aliu39
Revert "feat(feedback): add ff for ingest feedback topic (#67747)"
55de3d5 
This reverts commit bb59152.
@aliu39 aliu39 mentioned this pull request Mar 27, 2024
Closed
@aliu39 aliu39 added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Mar 27, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 5773dab

getsentry-bot added a commit that referenced this pull request Mar 27, 2024
@getsentry-bot @aliu39
Revert "feat(feedback): add ff for ingest feedback topic (#67747)"
5773dab 
This reverts commit bb59152.

Co-authored-by: aliu3ntry <159852527+aliu3ntry@users.noreply.github.com>
aliu39 added a commit to getsentry/relay that referenced this pull request Apr 9, 2024
@aliu39
feat(feedback): produce to ingest-feedback-events topic (#3344)
01311a4 
Option PR:
depends on getsentry/sentry#67839 (MERGED)

Feature flag PRs (outdated/unused):
~getsentry/getsentry#13426 (REVERTED)~
~getsentry/sentry#67747 (REVERTED)~
~getsentry/sentry-options-automator#973
(CLOSED)~

Relates to getsentry/sentry#66100
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dav1dde Dav1dde Dav1dde approved these changes

@cmanallen cmanallen Awaiting requested review from cmanallen

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aliu39 @michellewzhang @getsentry-bot @Dav1dde @cmanallen