feat(stacktrace): Add source_link on UI for .NET projects #55107
Conversation
There was a problem hiding this comment.
The Sentry SDK reports platform=csharp. This is for historical reasons. Happens that the SDK is written in C#, but .NET as a platform has different languages, and events from apps written in VB, or F#, also use the .NET SDK (and hence platform=csharp but everything works out fine
|
I imagine it's probably better to merge this after hackweek since it's 5 PM PST? |
|
Currently pending: #55407 |
| {frame.sourceLink && ( | ||
| <React.Fragment> | ||
| <IconFile /> | ||
| <OpenInLink onClick={onOpenLink} href={frame.sourceLink} openInNewTab> | ||
| {t('or open in source')} | ||
| </OpenInLink> | ||
| </React.Fragment> |
There was a problem hiding this comment.
temp example of using sourceLink when stacktrace linking is enabled but no provider integrations linked yet
There was a problem hiding this comment.
Do we want sourceLink to display always if there is no provider integration (ie. don't bother displaying "Tell us where your code is" as long as there is a source link available)? Or should we still give users the option to link source code (not sure if this is actually fully functional for C#)
Option 1Provide source link for every file that has it, regardless of whether that file has stack trace linking (which is only enabled for in app files in orgs that have the integration) Clicking on "Open in source" will take the user to the file linked in source_link, ie. raw githubuser content |
Option 2Only provide source link as an alternative to the stack trace linking when no provider integration is available yet (thus this would only be available for files that are in app and in orgs with the stack trace link integration) |
static/app/components/events/interfaces/frame/deprecatedLine.tsx
Outdated
Show resolved
Hide resolved
static/app/components/events/interfaces/frame/deprecatedLine.tsx
Outdated
Show resolved
Hide resolved
| @@ -52,6 +52,7 @@ const supportedStacktracePlatforms: PlatformKey[] = [ | |||
| 'python', | |||
| 'ruby', | |||
| 'elixir', | |||
| 'csharp', | |||
There was a problem hiding this comment.
i think this is no longer needed?
This PR adds .NET's source_link to the UI so users can directly access the file being referenced in a certain issue.