Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error.main_thread search fields to search keys on issues and discover page #47446

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 17, 2023

Follow up #46183

Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add this to Issue widgets in dashboards too since it's a valid query filter. You can make that change in static/app/views/dashboards/widgetBuilder/issueWidget/fields.tsx. Just gotta add a field key entry and put it in the ISSUE_FIELDS object with a boolean type.

@marandaneto
Copy link
Contributor Author

ISSUE_FIELDS

I didn't know about this class, nice, but there's no other error.something property, I'd be expecting all the others there too, ideas why?
I'll merge this to unblock this feature but I can do it in a separate PR if we want to go ahead.

@marandaneto marandaneto merged commit 6d0928d into master Apr 17, 2023
@marandaneto marandaneto deleted the chore/error-main-thread-search-keys branch April 17, 2023 14:31
@narsaynorath
Copy link
Member

I didn't know about this class, nice, but there's no other error.something property, I'd be expecting all the others there too, ideas why?

Good point, there are a lot of fields that aren't available there as columns. I recall now that we made an explicit choice to keep the column selections limited to a small subset but I'll have to follow up with why and what conditions mean we should add it to the column selector

@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants