Make error.main_thread searchable on Discover and Issues page

[marandaneto]

Depends on getsentry/snuba#3863

[marandaneto]

Do I need to add error.main_thread into the event_search.py file boolean_keys array?

[marandaneto]

Do I need to add error.main_thread into filter.py -> key_conversion_map?

[marandaneto]

I'm not adding a error.main_thread tag so I believe I don't need to change the backend.py -> get_tag_value_paginator_for_projects, right?

[marandaneto]

My PR is basically looking at error.handled usage, I have 0 knowledge of the Sentry codebase, help is appreciated, thanks.

[marandaneto]

@evanh or @untitaker would any of you be able to help me out with all those open questions? thanks.

[wmak]

I'm not familiar with the event_attribute code, but for discover all you should need to do is update src/sentry/snuba/events.py if there's no post-processing required

[marandaneto]

Do I need to change src/sentry/search/events/filter.py and src/sentry/search/events/datasets/discover.py? there are similar methods for isHandled, notHandled and isHandled, I just need error.main_thread:True or error.main_thread:False to work, does this need pre-post processing?

[wmak]

Do I need to add error.main_thread into the event_search.py file boolean_keys array?

Yes

Do I need to add error.main_thread into filter.py -> key_conversion_map?

No, filter.py is deprecated by src/sentry/search/events/datasets/discover.py, but you only need to add it there if you require special handling, eg. error.handled is actually the snuba function notHandled

Do I need to change src/sentry/search/events/filter.py and src/sentry/search/events/datasets/discover.py? there are similar methods for isHandled, notHandled and isHandled, I just need error.main_thread:True or error.main_thread:False to work, does this need pre-post processing?

No, from your other answer where this is just a boolean field, all you should need to do is update snuba.py -- see the previous answer for when you need to update those two files

[marandaneto]

Do I need to add error.main_thread into the event_search.py file boolean_keys array?

Yes

Do I need to add error.main_thread into filter.py -> key_conversion_map?

No, filter.py is deprecated by src/sentry/search/events/datasets/discover.py, but you only need to add it there if you require special handling, eg. error.handled is actually the snuba function notHandled

Do I need to change src/sentry/search/events/filter.py and src/sentry/search/events/datasets/discover.py? there are similar methods for isHandled, notHandled and isHandled, I just need error.main_thread:True or error.main_thread:False to work, does this need pre-post processing?

No, from your other answer where this is just a boolean field, all you should need to do is update snuba.py -- see the previous answer for when you need to update those two files

Alright, thanks, this has to be searchable on the Alert and Issues page as well, is there anyone that knows how this work? my tests are still broken, so I'm unsure what is wrong or what I have to do.

[marandaneto]

@barkbarkimashark @wmak tests are green and this is ready for approval/merging.
Thank you so much for your help.

[wmak]

Changes to discover code look good to me, a reminder you'll need to update the frontend too to see error.main_thread in autocompletes etc.