ref: Remove typing_extensions dep #29521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relaxolotl
approved these changes
Oct 22, 2021
wedamija
approved these changes
Oct 22, 2021
|
The docker build is running on 3.6 and is therefore failing. I don't know who should be updating that? I assume onpremise still runs on 3.6? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (I, lol) have added inconsistent uses of TypedDict to our codebase, so TypedDict is sometimes imported from mypy_extensions and sometimes from typing_extensions.
#29511 removes mypy_extensions parts, this removes all uses of typing_extensions (typeddict, literal, protocol)