Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removing TypedDict hack we had to use it early #29511

Merged
merged 3 commits into from
Oct 25, 2021
Merged

fix: Removing TypedDict hack we had to use it early #29511

merged 3 commits into from
Oct 25, 2021

Conversation

wmak
Copy link
Member

@wmak wmak commented Oct 22, 2021

  • This removes a hack we had to get TypedDict early by importing it only
    if we were type checking

@wmak
fix: Removing TypedDict hack we had to use it early
740f5c4 
- This removes a hack we had to get TypedDict early by importing it only
  if we were type checking
@wmak wmak requested review from a team October 22, 2021 14:48
@wmak wmak requested a review from a team as a code owner October 22, 2021 14:48
@evanh
Copy link
Member

evanh commented Oct 22, 2021

I don't know if this is relevant to you or not, but now we're on 3.8 we can also get rid of any times you had to type things using strings (request: "Request"), as long as you put from __future__ import annotations. I'm going to point this out on any typing PR for the next little bit lol.

untitaker
untitaker approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are probably more instances of typing_extensions that we can get rid of as well

@untitaker untitaker mentioned this pull request Oct 22, 2021
Merged
@wmak wmak enabled auto-merge (squash) October 22, 2021 18:18
@wmak wmak merged commit ff53f2c into master Oct 25, 2021
@wmak wmak deleted the wmak/fix/remove-typed-dict-hack branch October 25, 2021 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@untitaker untitaker untitaker approved these changes

@evanh evanh evanh approved these changes

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wmak @evanh @untitaker @Zylphrex