Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Hacks out use of session dict generator func #29484

Merged
merged 3 commits into from
Oct 22, 2021
Merged

ref: Hacks out use of session dict generator func #29484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d91556
ref: Hacks out use of session dict generator func
ahmedetefy Oct 21, 2021
02f9f5a
Use build_session rather than dict
ahmedetefy Oct 21, 2021
f9c5401
Hack out make_sessions in favor of build_sessions
ahmedetefy Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 19 additions & 46 deletions tests/sentry/incidents/test_logic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import time
import uuid
from datetime import datetime, timedelta

import pytest
Expand Down Expand Up @@ -287,40 +285,6 @@ def group_incident(self):
)


class BaseCrashRateAlertsTest(SnubaTestCase):
def setUp(self):
super().setUp()
self.session_release = "foo@1.0.0"
self.now = timezone.now().replace(minute=0, second=0, microsecond=0)

def make_session(
self,
received=None,
started=None,
status="ok",
):
if received is None:
received = time.time()
if started is None:
started = time.time() // 60 * 60

return {
"session_id": str(uuid.uuid4()),
"distinct_id": str(uuid.uuid4()),
"status": status,
"seq": 0,
"release": self.session_release,
"environment": "prod",
"retention_days": 90,
"org_id": self.project.organization_id,
"project_id": self.project.id,
"duration": 60.0,
"errors": 0,
"started": started,
"received": received,
}


@freeze_time()
class GetIncidentEventStatsTest(TestCase, BaseIncidentEventStatsTest):
@fixture
Expand Down Expand Up @@ -402,7 +366,11 @@ def test_with_transactions(self):


@freeze_time()
class GetIncidentSessionStatsTest(TestCase, BaseCrashRateAlertsTest, BaseIncidentsValidation):
class GetIncidentSessionStatsTest(TestCase, SnubaTestCase, BaseIncidentsValidation):
def setUp(self):
super().setUp()
self.now = timezone.now().replace(minute=0, second=0, microsecond=0)

def test_with_sessions(self):
alert_rule = self.create_alert_rule(
self.organization,
Expand All @@ -419,13 +387,13 @@ def test_with_sessions(self):
alert_rule=alert_rule,
)
for _ in range(3):
self.store_session(self.make_session(status="exited"))
self.store_session(self.make_session(status="crashed"))
self.store_session(self.build_session(status="exited"))
self.store_session(self.build_session(status="crashed"))

self._6_min_ago_dt = datetime.utcnow() - timedelta(minutes=6)
self._6_min_ago = self._6_min_ago_dt.timestamp()
self.store_session(
self.make_session(status="crashed", received=self._6_min_ago, started=self._6_min_ago)
self.build_session(status="crashed", received=self._6_min_ago, started=self._6_min_ago)
)
result = get_incident_session_stats(incident, windowed_stats=False)
self.validate_result(
Expand All @@ -451,11 +419,12 @@ def test_projects(self):
assert get_incident_aggregates(self.project_incident) == {"count": 4, "unique_users": 2}


class GetCrashRateIncidentAggregatesTest(TestCase, BaseCrashRateAlertsTest):
class GetCrashRateIncidentAggregatesTest(TestCase, SnubaTestCase):
def setUp(self):
super().setUp()
self.now = timezone.now().replace(minute=0, second=0, microsecond=0)
for _ in range(2):
self.store_session(self.make_session(status="exited"))
self.store_session(self.build_session(status="exited"))

def test_sessions(self):
incident = self.create_incident(
Expand Down Expand Up @@ -498,15 +467,19 @@ def test_simple(self):


@freeze_time()
class CreateSessionStatTest(TestCase, BaseCrashRateAlertsTest):
class CreateSessionStatTest(TestCase, SnubaTestCase):
def setUp(self):
super().setUp()
self.now = timezone.now().replace(minute=0, second=0, microsecond=0)

def test_simple(self):
for _ in range(2):
self.store_session(self.make_session(status="exited"))
self.store_session(self.make_session(status="crashed"))
self.store_session(self.build_session(status="exited"))
self.store_session(self.build_session(status="crashed"))
self._2_min_ago_dt = datetime.utcnow() - timedelta(minutes=2)
self._2_min_ago = self._2_min_ago_dt.timestamp()
self.store_session(
self.make_session(status="crashed", received=self._2_min_ago, started=self._2_min_ago)
self.build_session(status="crashed", received=self._2_min_ago, started=self._2_min_ago)
)

alert_rule = self.create_alert_rule(
Expand Down
Loading