Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Hacks out use of session dict generator func #29484

Merged
merged 3 commits into from
Oct 22, 2021
Merged

ref: Hacks out use of session dict generator func #29484

merged 3 commits into from
Oct 22, 2021

Conversation

ahmedetefy
Copy link
Contributor

Removes functions that generate default session
dictionary in tests to use build.session defined
on SnubaTestCase

@ahmedetefy ahmedetefy requested review from wedamija and a team October 21, 2021 14:22
wedamija
wedamija approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup, thanks!

@ahmedetefy @wedamija
ref: Hacks out use of session dict generator func
7d91556 
Removes functions that generate default session
dictionary in tests to use `build.session` defined
on `SnubaTestCase`
@ahmedetefy @wedamija
Use build_session rather than dict
02f9f5a
@ahmedetefy @wedamija
Hack out make_sessions in favor of build_sessions
f9c5401
@wedamija wedamija force-pushed the ahmed/refactor-sessions-test branch from 2559677 to f9c5401 Compare October 21, 2021 18:17
@wedamija wedamija merged commit 9887215 into master Oct 22, 2021
@wedamija wedamija deleted the ahmed/refactor-sessions-test branch October 22, 2021 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wedamija wedamija wedamija approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmedetefy @wedamija