-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(post-process-forwarder) Allow different types of post process forwarders #29225
Conversation
@@ -332,6 +338,7 @@ def post_process_forwarder(**options): | |||
|
|||
try: | |||
eventstream.run_post_process_forwarder( | |||
entity=options["entity"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would need to cast this to the enum type to avoid future typing errors I think. I can't remember if mypy is smart about Enums.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened a ticket to add mypy typing to the whole post process forwarder. I will handle it at that time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Context