Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(post-process-forwarder) Allow different types of post process forwarders #29225

Merged
merged 8 commits into from
Oct 15, 2021

Conversation

nikhars
Copy link
Member

@nikhars nikhars commented Oct 8, 2021

Context

  • In feat(post-process-forwarder) Different errors and transaction forwarders #28954, we created different processing strategies for errors and transactions post process forwarders.
  • In this PR, we enable post process forwarder to run with one of the following entities (errors, transactions, all)
  • The all option would be used in scenarios where we don't need separate post process forwarders. Example devserver, single tenant.
  • There is no production change with this code since the default option for entity is "all" which means the current post process forwarder would handle all messages

@nikhars nikhars requested a review from a team October 8, 2021 22:17
@@ -332,6 +338,7 @@ def post_process_forwarder(**options):

try:
eventstream.run_post_process_forwarder(
entity=options["entity"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to cast this to the enum type to avoid future typing errors I think. I can't remember if mypy is smart about Enums.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a ticket to add mypy typing to the whole post process forwarder. I will handle it at that time.

Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nikhars nikhars merged commit 7997cb9 into master Oct 15, 2021
@nikhars nikhars deleted the nikhar/entity-post-process-forwarder branch October 15, 2021 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants