feat(post-process-forwarder) Different errors and transaction forwarders #28954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added different Errors and Transactions post process forwarders. The errors one handles backward compatibility use case as well where the kafka header might be missing. These new classes aren't going to be used right now. They will be integrated in a different PR.
fpacifici
approved these changes
Sep 30, 2021
| forwarder = PostProcessForwarderWorker(concurrency=1) | ||
| @pytest.fixture | ||
| def kafka_message_without_transaction_header(kafka_message_payload): | ||
| mock_message = Mock() |
There was a problem hiding this comment.
Why using a mock for the message? Can't we just create a real Message object ?
There was a problem hiding this comment.
I tried using actual confluent_kafka.Message but it does not work. For example the set_headers expect Message objects rather than the actual headers. When I create a Message and pass it to set_headers, it barfs saying "cannot create 'cimpl.Message' instances".
I feel its fine to use mocks here, since they return values which would have been returned by the actual message when the api's like headers(), values() are called.
nikhars
added a commit
that referenced
this pull request
Oct 15, 2021
…rwarders (#29225) In feat(post-process-forwarder) Different errors and transaction forwarders #28954, we created different processing strategies for errors and transactions post process forwarders. In this PR, we enable post process forwarder to run with one of the following entities (errors, transactions, all) The all option would be used in scenarios where we don't need separate post process forwarders. Example devserver, single tenant. There is no production change with this code since the default option for entity is "all" which means the current post process forwarder would handle all messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added different Errors and Transactions post process forwarders. The
errors one handles backward compatibility use case as well where the
kafka header might be missing. These new classes aren't going to be
used right now. They will be integrated in a different PR.