Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(js): Correct useEffect dependencies in AppRoot #29143

Merged
merged 1 commit into from
Oct 7, 2021
Merged

ref(js): Correct useEffect dependencies in AppRoot #29143

merged 1 commit into from
Oct 7, 2021

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Oct 7, 2021 •
edited
Loading

I don't think this actually would matter since config wouldn't change here. But let's be exhaustive.

Follow up to #29138

@evanpurkhiser evanpurkhiser requested review from scttcper and a team October 7, 2021 07:03
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

size-limit report

Path Base Size (3a186e0) Current Size Change
src/sentry/static/sentry/dist/entrypoints/app.js 52.67 KB 52.68 KB +0.02% 🔺
src/sentry/static/sentry/dist/entrypoints/sentry.css 70.9 KB 70.9 KB 0%

@evanpurkhiser evanpurkhiser enabled auto-merge (squash) October 7, 2021 07:12
@evanpurkhiser evanpurkhiser merged commit 540a297 into master Oct 7, 2021
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-js-correct-useeffect-dependencies-in-approot branch October 7, 2021 07:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@priscilawebdev priscilawebdev priscilawebdev approved these changes

@scttcper scttcper Awaiting requested review from scttcper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @priscilawebdev