ref(js): useLegacyStore for config in AppRoot #29138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scttcper
reviewed
Oct 7, 2021
| @@ -21,7 +17,9 @@ type Props = { | |||
| * TODO: There might be an edge case where user does not have `lastOrganization` set, | |||
| * in which case we should load their list of organizations and make a decision | |||
| */ | |||
| function AppRoot({config}: Props) { | |||
| function AppRoot() { | |||
| const config = useLegacyStore(ConfigStore); | |||
There was a problem hiding this comment.
does config need to be passed to the useEffect?
There was a problem hiding this comment.
Yeah might as well. I don't think it will make any difference since config won't ever update while this is mounted, but let's be exhaustive.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.