ref(Slack): Allow users to enter a channel ID for alert rules on the front end #29125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
mgaeta
reviewed
Oct 6, 2021
static/app/views/alerts/incidentRules/triggers/actionsPanel/index.tsx
Outdated
Show resolved
Hide resolved
mgaeta
reviewed
Oct 6, 2021
static/app/views/alerts/incidentRules/triggers/actionsPanel/actionSpecificTargetSelector.tsx
Outdated
Show resolved
Hide resolved
mgaeta
suggested changes
Oct 6, 2021
mgaeta
approved these changes
Oct 7, 2021
static/app/views/alerts/incidentRules/triggers/actionsPanel/actionSpecificTargetSelector.tsx
Outdated
Show resolved
Hide resolved
static/app/views/alerts/incidentRules/triggers/actionsPanel/actionSpecificTargetSelector.tsx
Outdated
Show resolved
Hide resolved
static/app/views/alerts/incidentRules/triggers/actionsPanel/actionSpecificTargetSelector.tsx
Outdated
Show resolved
Hide resolved
static/app/views/alerts/incidentRules/triggers/actionsPanel/actionSpecificTargetSelector.tsx
Outdated
Show resolved
Hide resolved
static/app/views/alerts/incidentRules/triggers/actionsPanel/actionSpecificTargetSelector.tsx
Outdated
Show resolved
Hide resolved
static/app/views/alerts/incidentRules/triggers/actionsPanel/index.tsx
Outdated
Show resolved
Hide resolved
654f69c to
04c111b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially the UI version of the API approach implemented here: #24314 which allows a user to enter in their Slack channel ID in the event that they have too many channels and cannot save a rule due to them being rate limited. If they provide the channel ID, it will bypass the Slack channel lookup (it validates the entered name and ID are correct).