fix(post_process_group): Fix bug where has_reappared can be undefined
#29004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in #28986. If an exception occurs when calling `process_snoozes` we never end up defining `has_reappeared`, which causes an error later on. I tried to find instances of `Failed to add group to inbox for non-reprocessed groups` errors in Sentry and couldn't. I'm not sure why they're not present, but I can't see any other way that `has_reappeared` could be undefined. Fixes SENTRY-SAR
ahmedetefy
approved these changes
Sep 30, 2021
untitaker
approved these changes
Sep 30, 2021
|
For my understanding, the specific instances where this task crashes would have crashed earlier anyway, right? so it's not that we dropped more data because of this |
Yeah, that sounds right to me. This has affected 18 events total, so it's not a huge problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #28986. If an exception occurs when
calling
process_snoozeswe never end up defininghas_reappeared, which causes an error later on.I tried to find instances of
Failed to add group to inbox for non-reprocessed groupserrors inSentry and couldn't. I'm not sure why they're not present, but I can't see any other way that
has_reappearedcould be undefined.Fixes SENTRY-SAR