ref(tasks): Safeguard post_process_group with try/except [WOR-1319] #28986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Sep 30, 2021
vuluongj20
pushed a commit
that referenced
this pull request
Sep 30, 2021
wedamija
added a commit
that referenced
this pull request
Sep 30, 2021
This was introduced in #28986. If an exception occurs when calling `process_snoozes` we never end up defining `has_reappeared`, which causes an error later on. I tried to find instances of `Failed to add group to inbox for non-reprocessed groups` errors in Sentry and couldn't. I'm not sure why they're not present, but I can't see any other way that `has_reappeared` could be undefined. Fixes SENTRY-SAR
wedamija
added a commit
that referenced
this pull request
Sep 30, 2021
…ed (#29004) This was introduced in #28986. If an exception occurs when calling `process_snoozes` we never end up defining `has_reappeared`, which causes an error later on. I tried to find instances of `Failed to add group to inbox for non-reprocessed groups` errors in Sentry and couldn't. I'm not sure why they're not present, but I can't see any other way that `has_reappeared` could be undefined. Fixes SENTRY-SAR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch of
try/excepts inpost_process_groupto safeguard against alert being dropped in one of the functions logical componentsref: https://getsentry.atlassian.net/secure/RapidBoard.jspa?rapidView=91&projectKey=WOR&modal=detail&selectedIssue=WOR-1319