-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Query realtime_metrics for low priority selection [NATIVE-203] #28950
Conversation
…witch for the LPQ.
fb66f0c
to
0cc8c0b
Compare
d5e7f47
to
2f577f4
Compare
@loewenheim since i was responsible for the conflicts between this branch and i've also dropped some linting commits from santrybot which just incorrectly re-introduced dead files, as well as your follow-up commit to fix that linting commit from santrybot. |
regarding the project argument: after a bit of spelunking it looks like #14143 changed the contents of the params weren't changed in the PR to reflect the removal of all usages of that param, so |
2f577f4
to
105caa2
Compare
Follow-up to #28757.
should_demote_symbolication
will now, in addition to the killswitches, also take into account if a project is registered as low priority in theRealtimeMetricsStore
.As an aside, what's the deal with the
project
arguments tosubmit_symbolicate
andsubmit_process
? They're never used.