Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Query realtime_metrics for low priority selection [NATIVE-203] #28950

Merged
merged 27 commits into from
Oct 5, 2021

Conversation

loewenheim
Copy link
Contributor

Follow-up to #28757. should_demote_symbolication will now, in addition to the killswitches, also take into account if a project is registered as low priority in the RealtimeMetricsStore.

As an aside, what's the deal with the project arguments to submit_symbolicate and submit_process? They're never used.

@loewenheim loewenheim requested a review from a team September 29, 2021 17:00
@relaxolotl
Copy link
Contributor

@loewenheim since i was responsible for the conflicts between this branch and master, i've gone in and rebased + cleaned up the conflicts. the only major conflict i've noticed is from the signature change of add_project_to_lpq, and so all of the resolutions i've taken the liberty of patching up are related to that method and the code immediately surrounding it (e.g. add_project_to_lpq).

i've also dropped some linting commits from santrybot which just incorrectly re-introduced dead files, as well as your follow-up commit to fix that linting commit from santrybot.

@relaxolotl
Copy link
Contributor

regarding the project argument: after a bit of spelunking it looks like #14143 changed the contents of submit_process so it no longer relied on the project argument anymore. the original usage of it was to check feature flags on a project.

the params weren't changed in the PR to reflect the removal of all usages of that param, so project is very likely to be vestigial and safe to remove.

@loewenheim loewenheim force-pushed the feat/lpq/query-redis-selection branch from 2f577f4 to 105caa2 Compare October 5, 2021 08:48
@loewenheim loewenheim merged commit bbb0afe into master Oct 5, 2021
@loewenheim loewenheim deleted the feat/lpq/query-redis-selection branch October 5, 2021 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants