feat(symbolicator): Add the ability to manipulate the automatic killswitch for the LPQ #28757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
reviewed
Sep 22, 2021
Comment on lines
90
to
91
| if len(project_ids) == 0: | ||
| return set() |
There was a problem hiding this comment.
does this special case actually matter?
There was a problem hiding this comment.
the code below can definitely handle this - it's mostly a preoptimization so we skip talking to redis entirely if for some reason no project IDs are fed in. i'm assuming it's relatively costly to perform that round trip but i could be wrong and this specific check isn't necessary.
ab5cb38 to
c6e4437
Compare
becce7c to
6605e67
Compare
9efab96 to
804cbbf
Compare
5f4e036 to
20af86a
Compare
05afde5 to
307bb51
Compare
bab2136 to
8bf11bc
Compare
loewenheim
approved these changes
Sep 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of #28565 changes. Broken out of #28714 to reduce the size of that PR's diff.
This adds in methods to
RealtimeMetricsStoreto fetch, add, and remove projects from the automated kill switch (automated option?) stored on redis which specifies which projects should be sent to symbolicator's low priority queue.This does not include code to actually use these methods. Actual usages of the code in this PR will be included in #28714.
Open questions have been left as TODOs on the code, and feedback on those would be much appreciated. I also haven't done anything explicit to ensure any sort of locking on this value, which may be a problem. I'm currently unsure if this is something that's already taken care of by Redis, or if additional work needs to be done to ensure that this value is being safely manipulated in redis.